Added implementation for --noheading option for podman farm list - #29541
Added implementation for --noheading option for podman farm list#29541The-indigo wants to merge 1 commit into
Conversation
Honny1
left a comment
Honny1
left a comment
There was a problem hiding this comment.
LGTM
PTAL @podman-container-tools/podman-maintainers @podman-container-tools/podman-reviewers
| } | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
These extra lines can be trimmed
There was a problem hiding this comment.
I have removed the extra lines and done a rebase from the recent merged changes in main. Please verify and let me know if anything else needs to be worked on.
|
I suspect #29536 will go in first and this will probably need a rebase after |
|
LGTM |
Honny1
left a comment
Honny1
left a comment
There was a problem hiding this comment.
I think this failure seems to be seriouse:
xref-helpmsgs-manpages: 'podman farm list --help' lists '--noheading', which is not in docs/source/markdown/podman-farm-list.1.md
hack/xref-helpmsgs-manpages
xref-helpmsgs-manpages: 'podman farm list --help' lists '-n', which is not in docs/source/markdown/podman-farm-list.1.md
make: *** [Makefile:645: xref-helpmsgs-manpages] Error 1
|
|
||
| Print farm output in quiet mode. Only print the farm names. | ||
|
|
||
| @@option noheading |
There was a problem hiding this comment.
I think this won't properly expand.
|
[NON-BLOCKING] Packit jobs failed. @podman-container-tools/packit-jobs please check. Everyone else, feel free to ignore. |
Signed-off-by: Adeyemi Adepoju <adepojuadeyemi11@gmail.com>
| [//]: # (BEGIN included file options/noheading.md) | ||
| #### **--noheading**, **-n** | ||
|
|
||
| Omit the table headings from the listing. | ||
|
|
||
| [//]: # (END included file options/noheading.md) | ||
|
|
There was a problem hiding this comment.
that is not correct, you need to commit the .in file and options/noheading.md remove the main podman-farm-list.1.md from the git repo and then add it to .gitignore here in the directory.
4 participants
Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #00000in commit message (if applicable)make validatepr(format/lint checks)Noneif no user-facing changes)Does this PR introduce a user-facing change?
Pr description
This pr implements the --noheading option for podman farm list including the -n shorthand command. After adding the implementation, it was tested manually by running the cli command and the output is displayed as expected. Also, added the manfile and the system test in the respective files.This implementation lists the podman farms without the headers i.e (Name,Connections,Default,ReadWrite)
Cli command:
./bin/podman farm list --noheading
./bin/podman farm list -n